[Webkit-unassigned] [Bug 25102] TextMatches don't have a concept of active match

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25102


sullivan at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29371|review?                     |review-
               Flag|                            |




------- Comment #2 from sullivan at apple.com  2009-04-09 15:26 PDT -------
(From update of attachment 29371)
> Index: dom/Document.h
> ===================================================================
> --- dom/Document.h	(revision 42365)
> +++ dom/Document.h	(working copy)
> @@ -699,6 +699,8 @@ public:
>      void setRenderedRectForMarker(Node*, DocumentMarker, const IntRect&);
>      void invalidateRenderedRectsForMarkersInRect(const IntRect&);
>      void shiftMarkers(Node*, unsigned startOffset, int delta, DocumentMarker::MarkerType = DocumentMarker::AllMarkers);
> +    void setMarkersActive(Range*, bool);
> +    void setMarkersActive(Node*, unsigned, unsigned, bool);

The two unsigned parameters here should be given names in this declaration
since it's otherwise not clear what they represent.

The patch otherwise seems fine to me. Please submit a new patch with this
change.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.