[Webkit-unassigned] [Bug 21546] [GTK] ATK accessibility enhancements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21546





------- Comment #25 from zecke at selfish.org  2009-04-09 04:06 PDT -------
(From update of attachment 29361)

> +#if PLATFORM(GTK)
> +#include "HostWindow.h"
> +#include <gtk/gtk.h>
> +#endif

I don't think we need this conditional.


> +    if (frameView) {
> +#if PLATFORM(GTK)
> +        // FIXME: This is a workaround for confusing coordinate conversions
> +        // that don't work in WebCore

maybe explain in which it is confusing?

> +        GtkWidget* widget = frameView->hostWindow()->platformWindow();
> +        GdkWindow* win = widget->window;
> +        rect = frameView->contentsToWindow(rect);
> +        rect.move(widget->allocation.x, widget->allocation.y);
> +
> +        if (coordType == ATK_XY_SCREEN) {
> +            gint originX, originY;
> +            gdk_window_get_origin(win, &originX, &originY);
> +            rect.move(originX, originY);
> +        }

Let us assume Atk is only used with the Gtk+ platform for now.

>
> +static IntPoint contentsFromAtk(AccessibilityObject* coreObject, AtkCoordType coordType, gint x, gint y)
> +{
> +    IntPoint pos(x, y);
> +
> +    FrameView* frameView = coreObject->documentFrameView();
> +    if (frameView) {
> +        switch (coordType) {
> +        case ATK_XY_SCREEN:
> +            return frameView->screenToContents(pos);
> +        case ATK_XY_WINDOW:
> +            return frameView->windowToContents(pos);
> +        }

So the confusion is not symmetric or is this part not yet tested?

> +  
>    switch (type) {
> -    case WAI_ACTION:
> +  case WAI_ACTION:
>        return ATK_TYPE_ACTION;
> -    case WAI_STREAMABLE:
> +  case WAI_STREAMABLE:
>        return ATK_TYPE_STREAMABLE_CONTENT;
> -    case WAI_EDITABLE_TEXT:
> +  case WAI_EDITABLE_TEXT:
>        return ATK_TYPE_EDITABLE_TEXT;
> -    case WAI_TEXT:
> +  case WAI_TEXT:
>        return ATK_TYPE_TEXT;
> +  case WAI_COMPONENT:
> +      return ATK_TYPE_COMPONENT;
>    }

please ix this when landing the dynamic types patch.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.