[Webkit-unassigned] [Bug 21546] [GTK] ATK accessibility enhancements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21546





------- Comment #23 from xan.lopez at gmail.com  2009-04-09 03:45 PDT -------
(In reply to comment #21)
> (From update of attachment 29326 [review])
> 
> > +static GType GetAtkInterfaceTypeFromWAIType(WAIType type)
> > +{
> > +  switch (type) {
> > +    case WAI_ACTION:
> > +      return ATK_TYPE_ACTION;
> > +    case WAI_STREAMABLE:
> > +      return ATK_TYPE_STREAMABLE_CONTENT;
> > +    case WAI_EDITABLE_TEXT:
> > +      return ATK_TYPE_EDITABLE_TEXT;
> > +    case WAI_TEXT:
> > +      return ATK_TYPE_TEXT;
> > +  }
> > +
> > +  return G_TYPE_INVALID;
> > +}
> 
> style foobar... four spaces please and the case labels should be on the same
> height as the switch (consult the style guide I might be wrong about the
> switch).
> 

Yep, I fixed this in another patch.

> 
> > +#define WAI_TYPE_NAME_LEN (30) /* Enough for prefix + 5 hex characters (max) */
> > +    static char name[WAI_TYPE_NAME_LEN + 1];
> > +    
> > +    g_sprintf(name, "WAIType%x", interfaceMask);
> > +    name[WAI_TYPE_NAME_LEN] = '\0';
> 
> nice improvement.  I have no idea where W should come from AI == a11y here?
> 

WAI = WebKit Accessibility Interface. Mozilla has MAI, so we get WAI ;)
At first I was writing the whole thing, but it really is just too long IMHO,
especially for API.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.