[Webkit-unassigned] [Bug 24539] Unresolved CSSMutableStyleDeclaration

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24539


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com




------- Comment #6 from eric at webkit.org  2009-04-09 01:46 PDT -------
(In reply to comment #4)
> Eric, I think that's wrong. Normally a forward declaration is sufficient even
> if the file does define a RefPtr, as long as the header doesn't contain any
> code that actually needs to manipulate the RefPtr. Are you sure this is a good
> change?

Again, this is one of those c++ questions where I'm gonna trust your (lengthy)
c++ experience over my own... but in this case, I think the instantiation of
PassRefPtr<CSSMutableStyleDeclaration> via:

6           static PassRefPtr<RemoveCSSPropertyCommand> create(Document*
document, PassRefPtr<CSSMutableStyleDeclaration> style, CSSPropertyID property)
37          {
38              return adoptRef(new RemoveCSSPropertyCommand(document, style,
property));
39          }

is going to require actually including CSSMutableStyleDeclaration.h so that
PassRefPtr can see that CSSMutableStyleDeclaration actually has a ref() method,
no?

I'm still confused by why the Symbian build would fail here and no other port
would, but I don't see including this header as harmful, if
PassRefPtr<CSSMutableStyleDeclaration> instantiation does really require the
full class definition.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.