[Webkit-unassigned] [Bug 25087] Test ENABLE_FOO macros consistently in IDL files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25087


ddkilzer at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-                     |ddkilzer at webkit.org
                   |unassigned at lists.webkit.org |
             Status|NEW                         |ASSIGNED
  Attachment #29322|                            |review?
               Flag|                            |




------- Comment #1 from ddkilzer at webkit.org  2009-04-07 17:56 PDT -------
Created an attachment (id=29322)
 --> (https://bugs.webkit.org/attachment.cgi?id=29322&action=view)
Patch v1

Proposed fix.

All the ports appear to be using the generate-bindings.pl script and only
defining macros if they intend the feature to be enabled, so I propose
changing:

#if ENABLE_FOO

to:

#if defined(ENABLE_FOO)

rather than:

#if defined(ENABLE_FOO) && ENABLE_FOO

Since there is currently a mix of the first two (and there are no apparent
build issues), I think this is safe to do.  Comments?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the assignee for the bug, or are watching the assignee.