[Webkit-unassigned] [Bug 24168] RTL: Home/End key does not behave correctly in mixed bidi text in RTL document

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24168


xji at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29296|                            |review?
               Flag|                            |




------- Comment #6 from xji at chromium.org  2009-04-06 17:31 PDT -------
Created an attachment (id=29296)
 --> (https://bugs.webkit.org/attachment.cgi?id=29296&action=view)
patch w/ Layout test

Looks like I can use the comparison of bidi resolver's lastRun() and
logicallyLastRun() to check whether the logic last node is the visual last node
or not. 

If a line is an RTL line and its visual last node is not the same as its logic
last node, its logic last node is its visual start node, such as bidi text in a
RTL div, or <div dir=rtl> abc <span dir="rtl"> efg hij </span> xyz </div>.
Otherwise, its logic last node is the same as its visual last node, such as 
<div dir=rtl> abc <span style="direction:rtl"> efg hij </span> xyz </div>.

The same applies to logic start node.

This patch fixes the attached 2 test cases: bidi text in RTL document and RTL
text with inline RTL element.

Please be noted:
1. I am fixing the home/end key in "move" + "right"/"left", not "move" +
"forward"/"backward".
But I think it should be fixed in "move" + "foward"/"backward".

2. All tests passed, but there are 22 tests with stderr output.
They looks like environment problem, and I do not think they are related to my
change.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.