[Webkit-unassigned] [Bug 25059] Remove references to dominantScript, getGenericFontForScript

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25059


dglazkov at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29282|                            |review?
               Flag|                            |




------- Comment #2 from dglazkov at chromium.org  2009-04-06 11:25 PDT -------
Created an attachment (id=29282)
 --> (https://bugs.webkit.org/attachment.cgi?id=29282&action=view)
WebCore:


2009-04-06  Dave Moore  <davemoore at google.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25031
        Make the V8 element collections check for named properties *before*
        checking if there are any elements with the same name. Otherwise
        it is both incorrect and slow.

        Test: fast/dom/HTMLSelectElement/length-not-overridden.html

        Both of these interceptors were attempting to find an element in the
        collection that had a name or id of the property name before checking
        for a JS property with that name.
        * bindings/v8/V8Collection.h:
        (WebCore::collectionNamedPropertyGetter):
        (WebCore::nodeCollectionNamedPropertyGetter):

LayoutTests:

2009-04-06  Dave Moore  <davemoore at google.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25031
        Test for ensuring that named elements don't override properties on
collections

        * fast/dom/HTMLSelectElement/length-not-overridden-expected.txt: Added.
        * fast/dom/HTMLSelectElement/length-not-overridden.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42247
268f45cc-cd09-0410-ab3c-d52691b4dbfc
---
 LayoutTests/ChangeLog                              |   10 +++++
 .../length-not-overridden-expected.txt             |    4 ++
 .../HTMLSelectElement/length-not-overridden.html   |   37 ++++++++++++++++++++
 WebCore/ChangeLog                                  |   18 +++++++++
 WebCore/bindings/v8/V8Collection.h                 |   18 +++++++++
 5 files changed, 87 insertions(+), 0 deletions(-)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.