[Webkit-unassigned] [Bug 25031] Chrome allows elements with names to override collection properties

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25031


dglazkov at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29233|review?(dglazkov at chromium.or|review-
               Flag|g)                          |




------- Comment #2 from dglazkov at chromium.org  2009-04-03 11:19 PDT -------
(From update of attachment 29233)
Don't forget bug URL in ChangeLog description.

> +        (WebCore::collectionNamedPropertyGetter):
> +        (WebCore::nodeCollectionNamedPropertyGetter):

It's a good practice to add brief descriptions to each line on what's being
done.

> +        if (!value.IsEmpty())
> +          return value;

4 spaces.

> +
> +        // Search local callback properties next to find IDL defined
> +        // properties.
> +        if (info.Holder()->HasRealNamedCallbackProperty(name))
> +          return v8::Handle<v8::Value>();

4 spaces.

Also, I think this should be return notHandledbyInterceptor().

> +        if (!value.IsEmpty())
> +          return value;

4 spaces.

> +        if (info.Holder()->HasRealNamedCallbackProperty(name))
> +          return v8::Handle<v8::Value>();

4 spaces, notHandledByInterceptor()

> +2009-04-03  Dave Moore  <davemoore at google.com>
> +
> +        Reviewed by NOBODY (OOPS!).

Need a good description of what the tests test.

> +            function test()
> +            {
> +                if (window.layoutTestController)
> +                    layoutTestController.dumpAsText();

Is this where we should put attempting to override length?

> +
> +                var sl = document.getElementById("sl");
> +                if (sl.length == 1)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.