[Webkit-unassigned] [Bug 25023] [Qt]Eliminating a leak in QNetworkReplyHandler

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25023


hausmann at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29223|review?(hausmann at webkit.org)|review-
               Flag|                            |




------- Comment #2 from hausmann at webkit.org  2009-04-03 07:28 PDT -------
(From update of attachment 29223)
I agree that there's probably a leak, but the purpose of release() is to
transfer the ownership to the caller. If we don't reset m_reply to 0 a
subsequent call to release() will return a pointer to the object whos ownership
we transferred to the previous caller. In other words: I think the caller in
abort() for example should call deleteLater on the reply(). Does that work for
you?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.