[Webkit-unassigned] [Bug 22898] [GTK] need proper API for printing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22898





------- Comment #38 from gns at gnome.org  2009-04-03 07:01 PDT -------
(In reply to comment #36)
> (From update of attachment 29121 [review])
> 
> > -        g_signal_connect(dialog, "response", G_CALLBACK(gtk_widget_destroy), NULL);
> > +        g_signal_connect(dialog, "response", G_CALLBACK(gtk_widget_destroy), 0);
> 
> unrelated but okay.

This was actually a mistake. We have agreed to use NULL on API files, so the
second one is correct!

> > +    Frame* coreFrame = core(frame);
> > +    if (!coreFrame)
> > +        return GTK_PRINT_OPERATION_RESULT_CANCEL
> 
> Why this and not GTK_PRINT_OPERATION_RESULT_ERROR?

My thinking was that the operation has not been attempted, so no error
happened. It was cancelled because the frame it was supposed to print does not
exist, but on second thought, given that we are in the context of
WebKitWebFrame, and that CANCEL also means 'print settings should not be
stored', I think ERROR is a better option indeed.

> >  #include <glib-object.h>
> > +#include <gtk/gtk.h>
> 
> oh interesting, the first Gtk+ symbol here :)

I guess we could move all this to WebKitWebView, and we would have stuff such
as:

GtkPrintOperationResult webkit_web_view_print_frame(WebKitWebView* view,
WebKitWebFrame* frame, GError* error);
GtkPrintOperationResult webkit_web_view_print_frame_full(WebKitWebView* view,
WebKitWebFrame* frame, GtkPrintOperation* operation, GtkPrintOperationAction
action, GError* error);

> Yeah, this and the test case look pretty good.

=)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.