[Webkit-unassigned] [Bug 22898] [GTK] need proper API for printing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22898





------- Comment #36 from zecke at selfish.org  2009-04-02 23:40 PDT -------
(From update of attachment 29121)

> -        g_signal_connect(dialog, "response", G_CALLBACK(gtk_widget_destroy), NULL);
> +        g_signal_connect(dialog, "response", G_CALLBACK(gtk_widget_destroy), 0);

unrelated but okay.



> +    GtkWidget* topLevel = gtk_widget_get_toplevel(GTK_WIDGET(webkit_web_frame_get_web_view(frame)));
> +    if (!GTK_WIDGET_TOPLEVEL(topLevel))
> +        topLevel = NULL;

not consistent with the one above :)


> +
> +    Frame* coreFrame = core(frame);
> +    if (!coreFrame)
> +        return GTK_PRINT_OPERATION_RESULT_CANCEL

Why this and not GTK_PRINT_OPERATION_RESULT_ERROR?



> --- a/WebKit/gtk/webkit/webkitwebframe.h
> +++ b/WebKit/gtk/webkit/webkitwebframe.h
> @@ -22,6 +22,8 @@
>  #define WEBKIT_WEB_FRAME_H
>  
>  #include <glib-object.h>
> +#include <gtk/gtk.h>

oh interesting, the first Gtk+ symbol here :)


Yeah, this and the test case look pretty good.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.