[Webkit-unassigned] [Bug 24986] ARM JIT port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24986





------- Comment #6 from barraclough at apple.com  2009-04-02 15:26 PDT -------
Hi Akos, Gabor, Zoltan,

Congratulations on getting this working!, great job.

As Oliver says (and as I'm sure is clear from the changes that have been going
into the repository over the last months) we have been abstracting out the
major architectural differences in the JIT through use of the MacroAssembler
interface with a very clear direction of allowing the core of the JIT to remain
as common code shared across architectures.  Our main concern with having the
functionality of the JIT duplicated (and effectively forked) will be that
engine changes we make will be prone to break the ARM JIT, which we will not be
in a position to maintain.  As such, if the JIT is to be forked it would seem
to make most sense for it to exist in a fork of WebKit, so we are not
continually breaking you?

However, if you are interested in landing this into trunk, from the limited
chance I've had to look at your code I'd say your port looks structurally
similar enough to the existing JIT that it should be quite possible to merge
the two back together.  I see no obvious barriers to moving your code over to
using a MacroAssembler interface matching that of the existing JIT.  If then
the names of a few internal functions are brought into line with each other
(accessing virtual registers, etc), then the two pieces of code should start
looking rather similar.  I'd also suggest that porting WREC may help here,
since the code generation is very simple, and almost entirely abstracted
through the MacroAssembler interface.  Once you have implemented the
MacroAssembler class (which should be a fairly trivial wrapper on your
ArmAssembler) there are only three very short calling-convention functions in
WREC that should need any modification.

thanks & good luck,
G.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.