[Webkit-unassigned] [Bug 24844] Unit test WebKitDownload

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24844


ap at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29163|review?                     |review+
               Flag|                            |




------- Comment #5 from ap at webkit.org  2009-04-02 08:12 PDT -------
(From update of attachment 29163)
> +        Extra checks to avoid crashing and a critical message when
> +	property accessor functions are called before the download is
> +	started.

Tabs instead of spaces here.

> +    if (!priv->timer)
> +        return 0.0;

I'd just write "return 0".

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.