[Webkit-unassigned] [Bug 24900] Render empty optgroup elements.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24900





------- Comment #5 from darin at apple.com  2009-04-01 13:46 PDT -------
(From update of attachment 29027)
> -        if (current->hasTagName(optgroupTag) && current->firstChild()) {
> -            // FIXME: It doesn't make sense to add an optgroup to the list items,
> -            // when it has children, but not to add it if it happens to have,
> -            // children (say some comment nodes or text nodes), yet that's what
> -            // this code does!
> +        // optgroup tags may not nest. However, both FireFox and IE will
> +        // flatten the tree automatically, so we follow suit.
> +        // (http://www.w3.org/TR/html401/interact/forms.html#h-17.6)
> +        if (current->hasTagName(optgroupTag)) {
>              m_listItems.append(static_cast<HTMLElement*>(current));
> -            current = current->firstChild();
> -            // FIXME: It doesn't make sense to handle an <optgroup> inside another <optgroup>
> -            // if it's not the first child, but not handle it if it happens to be the first
> -            // child, yet that's what this code does!
> +            if (current->firstChild())
> +                current = current->firstChild();
>          }

This doesn't look right. What if current->firstChild() is another optgroup?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.