[Webkit-unassigned] [Bug 19743] Release build fails on Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19743


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29173|                            |review-
               Flag|                            |




------- Comment #8 from aroben at apple.com  2009-04-01 12:27 PDT -------
(From update of attachment 29173)
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 42150)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,21 @@
> +2009-04-01  Ben Murdoch  <benm at google.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Combines all the HTML element cpp files into one to help reduce the size of WebCore.lib so we can build in release mode on 32bit Windows.
> +
> +        * WebCore.vcproj/WebCore.vcproj:
> +        * html/HTMLElements.cpp: Added.
> +
> +2009-04-01  Ben Murdoch  <benm at google.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Reduce the size of WebCore.lib so we can continue building release mode on 32 bit Windows.
> +
> +        * WebCore.vcproj/WebCore.vcproj:
> +        * html/HTMLElements.cpp: Added.
> +

You have two ChangeLog entries here. It would be good to mention this bug in
your ChangeLog entry.

> @@ -12638,103 +12638,51 @@
>  				>
>  			</File>
>  			<File
> -				RelativePath="..\html\HTMLAnchorElement.cpp"
> -				>
> -				<FileConfiguration
> -					Name="Release_PGO|Win32"
> -					>
> -					<Tool
> -						Name="VCCLCompilerTool"
> -						WholeProgramOptimization="true"
> -					/>
> -				</FileConfiguration>
> -			</File>
> -			<File

I think rather than removing the .cpp files from the project entirely (as was
unfortunately done for SVG), it would be better to use the "Excluded From
Build" option (right-click on the file, go to Configuration Properties >
General). That way the .cpp files will still be accessible from the Solution
Explorer. Eventually we should put the SVG .cpp files back into the .vcproj
using this method.

> Property changes on: WebCore/html/HTMLElements.cpp
> ___________________________________________________________________
> Added: svn:executable
>    + *

You should remove this property. We also normally set svn:eol-style to native
for new files.

Maybe the new file should have "AllInOne" in its name? That would match
JavaScriptCore's AllInOneFile.cpp and SVGAllInOne.cpp.

r- for now, but I don't think it will be much work to get this commitable!


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.