[Webkit-unassigned] [Bug 20924] [Gtk] Linux/Gtk: Recent tree revisions fail Acid2 and Acid3

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20924


alp at nuanti.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23893|review?                     |review-
               Flag|                            |




------- Comment #12 from alp at nuanti.com  2008-09-29 16:58 PDT -------
(From update of attachment 23893)
Mario,

Sorry about my terse reply earlier -- I may not have explained the issue fully.

The change in r35954 needs to be backed out not just because it regressed the
GLib code path but because it's wrong on all platforms: it introduces the
incorrect assumption that all data URLs are Base64-encoded, whereas we're meant
to support non-encoded data URLs as well.

The logic in parseDataUrl() function is pretty messy/difficult to follow but it
was essentially correct for both GLib and non-GLib before r35954 (except for
the loss when going back to a string in the non-GLib code path which you
noticed).

If you study this function (as it was before r35954) you'll see what I'm
getting at and why your latest change isn't correct either. Personally I'd love
to see this stupid function rewritten as it totally obfuscates a simple task.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.