[Webkit-unassigned] [Bug 15597] [GTK] Text not discernable when using a dark Gtk+ style
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 29 13:24:10 PDT 2008
https://bugs.webkit.org/show_bug.cgi?id=15597
------- Comment #2 from alp at nuanti.com 2008-09-29 13:24 PDT -------
The fix for this is straightforward, but needs a little testing to make sure it
works consistently with dark and light themes and matches GTK+ appearances as
closely as possible.
What needs to be done to make this work:
In RenderThemeGtk.cpp, we need to adjust the CSS style's colors to match what
GTK+ would use.
void RenderThemeGtk::adjustTextFieldStyle(CSSStyleSelector* selector,
RenderStyle* style, Element* e) const
{
...
+ style->setColor(gtkEntry()->style->text[GTK_STATE_NORMAL]);
+ style->setBackgroundColor(gtkEntry()->style->base[GTK_STATE_NORMAL]);
...
}
void RenderThemeGtk::adjustButtonStyle(CSSStyleSelector* selector,
RenderStyle* style, WebCore::Element* e) const
{
...
+ if (gButtonWidget) {
+ printf ("gButtonWidget()\n");
+ style->setColor(gButtonWidget->style->fg[GTK_STATE_NORMAL]);
+ style->setBackgroundColor(gButtonWidget->style->bg[GTK_STATE_NORMAL]);
+ }
...
}
Don't have time to make a patch right now. If someone can pick this up, it'd be
great and I'll be happy to review.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list