[Webkit-unassigned] [Bug 21197] New: SVN trunk (Revision: 36997) crashes after loading Flash Plugin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21197

           Summary: SVN trunk (Revision: 36997) crashes after loading Flash
                    Plugin
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Other
               URL: http://youtube.com
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: vdavidenko at mac.com


In the file WebCore/plugins/gtk/PluginViewGtk.cpp the function
PluginView::init() crashes on the line 
'ws->display = GDK_WINDOW_XDISPLAY(platformPluginWidget()->window);'
because of the platformPluginWidget()->window is 0.

Looks like the init code is expecting not null containingWindow() on the line
'gtk_container_add(GTK_CONTAINER(containingWindow()), platformPluginWidget());'

 I have modified the file WebCore/platform/ScrollView.cpp as a workaround(not
tested, only to provide correct value of containingWindow() ). After
modification below, flash is displayed.

$ svn diff WebCore/platform/ScrollView.cpp
Index: WebCore/platform/ScrollView.cpp
===================================================================
--- WebCore/platform/ScrollView.cpp     (revision 36997)
+++ WebCore/platform/ScrollView.cpp     (working copy)
@@ -43,12 +43,12 @@
 void ScrollView::addChild(Widget* child) 
 {
     ASSERT(child != this && !child->parent());
-    child->setParent(this);
-    m_children.add(child);
     if (!child->platformWidget()) {
         child->setContainingWindow(containingWindow());
-        return;
+//        return;
     }
+    child->setParent(this);
+    m_children.add(child);
     platformAddChild(child);
 }


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.