[Webkit-unassigned] [Bug 20287] [Gtk] disable plugins for gtk/directfb target

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 27 00:33:49 PDT 2008


https://bugs.webkit.org/show_bug.cgi?id=20287





------- Comment #7 from jmalonzo at gmail.com  2008-09-27 00:33 PDT -------
(In reply to comment #6)
> (From update of attachment 23702 [edit])
> I think PLATFORM(X11) is a good direction since we may want to share plugin
> code between more ports some day.
> 
> Will your checks still work using only #if PLATFORM(X11) without checking
> GDK_WINDOWING_X11 at all? That would be cleaner.

Yup. It does. I don't think we need GDK_WINDOWING_X11 anymore as we're checking
for gtk-x11 package anyway.

> This check is wrong:
> 
> +/* Windowing Systems */
> +#if PLATFORM(GTK) && !PLATFORM(WIN) && !PLATFORM(DIRECTFB)
> +#define WTF_PLATFORM_X11 1
> +#endif
> +
> 
> It should be PLATFORM(WIN_OS). But moreover, I'd prefer if we define this only
> in the build system without touching Platform.h at all. This sounds like an
> opportunity to start making use of AC_DEFINE in configure.ac

Ok.

> 
> +   PKG_CHECK_MODULES(CAIRO, cairo-directfb >= $CAIRO_REQUIRED_VERSION)
> +   PKG_CHECK_MODULES(GTK, gtk+-directfb-2.0 >= $GTK_REQUIRED_VERSION)
> 
> ^ I Don't think we actually need to check for either of these packages, since
> we don't actually use any cairo-directfb or gtk+-directfb-2.0 features
> directly, even when DirectFB is the target. I don't mind strongly if we add
> these checks though, your call.

I added the checks since the .pc files nicely sets up the dependencies for us
as well as location of directfb or x11 libraries.

Patch coming.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list