[Webkit-unassigned] [Bug 21116] Audio from <audio> or <video> element continues after tab is closed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 26 09:31:45 PDT 2008


https://bugs.webkit.org/show_bug.cgi?id=21116


koivisto at iki.fi changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23851|review?(koivisto at iki.fi)    |review+
               Flag|                            |




------- Comment #7 from koivisto at iki.fi  2008-09-26 09:31 PDT -------
(From update of attachment 23851)
This should still be renamed to match variable name for consistency:

bool inPageCache() const { return !m_inActiveDocument; }

It should return the value without negation and call sites and should be
reversed instead. (or alternatively find a good variable name that is true when
inactive, m_inInactiveDocument sounds bad).

This is minor, r=me with or without the change.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list