[Webkit-unassigned] [Bug 21124] New: --pixel should be ignored for tests that use dumpAsText()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 25 16:59:21 PDT 2008


           Summary: --pixel should be ignored for tests that use
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh Intel
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: pol at apple.com

If I understand things right, tests that use the dumpAsText() instead of
dumping the render tree are supposed to be platform agnostic, so their results
are in the same directory as the tests instead of in "platform".

Pixel test are by definition not platform agnostic (destination screen color
profile, font rendering differences, etc...), so their result should always be
in "platform".

If you combine these two assumptions, then having a test that uses dumpAsText()
also have its rendering be pixel-tested does not make sense.
But today, if you run "WebKitTools/Scripts/run-webkit-tests --pixel
LayoutTests/", it will generate images for such tests.

For instance, 3 out of the 6 tests in LayoutTests/transforms/2d are
dumpAsText() tests and do not print the render tree:
- compound-2d-transforms.html
- transform-2d.html
- transform-accuracy.html
But since there are no "base" images in LayoutTests/platform/mac/transforms/2d
for these tests, DRT always creates news ones in LayoutTests/transforms/2d and
this pollutes the directory.

I think the DRT tool when running in --pixel-test mode should not compare pixel
rendering of tests that use dumpAsText().

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list