[Webkit-unassigned] [Bug 20092] Spelling markers positioned incorrectly in RTL text

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 24 15:07:40 PDT 2008


mitz at webkit.org changed:

           What    |Removed                     |Added
  Attachment #23761|review?                     |review-
               Flag|                            |

------- Comment #10 from mitz at webkit.org  2008-09-24 15:07 PDT -------
(From update of attachment 23761)
Looks great! I did notice a couple of issues, though, now that the code is
cleaned up:

+            endPosition = min(endPosition, startPosition + m_truncation);      

That looks wrong, because m_truncation is relative to m_start, not

+        IntPoint startPoint = IntPoint(tx, ty);

The current WebKit style for writing this is:
IntPoint startPoint(tx, ty);

However, the y coordinate is wrong. Currenrly, it is ty + selectionTop(), which
is also wrong since earlier m_y is added to ty. This means that grammar "tool
tips" only work in the first line of text in a block. What you really want
there is the passed-in ty + selectionTop().


Extra white space.

Sorry about not catching the above earlier. I am going to r- because the
endPosition issue looks like a regression.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list