[Webkit-unassigned] [Bug 21022] New: bugs.webkit.org should discourage patches larger than 20k (or some arbitrary size)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 23 04:50:44 PDT 2008


https://bugs.webkit.org/show_bug.cgi?id=21022

           Summary: bugs.webkit.org should discourage patches larger than
                    20k (or some arbitrary size)
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Website
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org


bugs.webkit.org should discourage patches larger than 20k (or some arbitrary
size)

I think our tools could assist us here.  I think it could be helpful towards
education of contributers, and towards sanity of reviewers, if bugs.webkit.org
would display some sort of warning page when you tried to upload a patch which
was larger than 50k/20k or some arbitrary size.  Especially when non-committers
or first-time contributers upload 100k patches, its just a waste of reviewers
time and their time, trying to fight it down to something that's more
reviewable.  I don't think technology is the final solution to that problem,
but making it clear during the patch upload process that your patch exceeds the
"sane" size limit, could be useful.

Heck there are other things bugzilla (or other scripts/tools) could scan for,
like lack of ChangeLog too... but that's the subject for another bug.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list