[Webkit-unassigned] [Bug 20277] implement window.scrollByPages and window.scrollByLines

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20277





------- Comment #20 from eric at webkit.org  2008-09-23 04:06 PDT -------
(From update of attachment 23490)
Hyatt just re-wrote large hunks of the scrollbar code, it may be possible to
write this differently now.

A couple nits:

+void DOMWindow::scrollByLines(int y) const
+void DOMWindow::scrollByPages(int y) const

Really should have better argument names, like:
+void DOMWindow::scrollByLines(int lines) const

+void DOMWindow::scrollByPages(int pages) const

Same here:
+        void scrollByLines(int y) const;
+        void scrollByPages(int y) const;

And here:
+        [RequiresAllArguments] void scrollByLines(in long y);
+        [RequiresAllArguments] void scrollByPages(in long y);

This differs from WebKit style:
+    RenderView *renderer = m_frame->contentRenderer();


This needs a comment (IMO):
+#if !PLATFORM(QT)

to explain that we can't turn this code on for Qt due to lack of primaryFont().
 That said, the Qt guys were just in teh middle of re-writing the qt font code
to be more like all the other platforms.  I'm not sure if that's landed or not
yet.  If it has, those #ifs can go away. :)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.