[Webkit-unassigned] [Bug 21011] New: Need to clean up fix in PropertyWrapperGetter::equals a bit (and add test case)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21011

           Summary: Need to clean up fix in PropertyWrapperGetter::equals a
                    bit (and add test case)
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: cmarrin at apple.com


The fix in changelist 36703 has one remaining problem. The test:

    if ((!a || !b) && b != a)

will fall through in the case where both a and b are null, causing a crash in
the deref on the next line. There is no evidence that it is possible for this
to happen, but I think the patch I have submitted is a bit safer. The patch
also includes a testcase for the crash.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.