[Webkit-unassigned] [Bug 20746] Port WebKit to Qt on Windows CE

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 21 14:29:56 PDT 2008


https://bugs.webkit.org/show_bug.cgi?id=20746


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23340|review?(aroben at apple.com)   |review-
               Flag|                            |




------- Comment #26 from darin at apple.com  2008-09-21 14:29 PDT -------
(From update of attachment 23340)
We prefer to use inline functions instead of macros for cases like this. Look
at the inline function for strncasecmp right below for an example of what I'm
talking about.

(If we did use macros, we'd want to use macros with argument names rather than
just doing the name of the function alone, but that's a moot point -- lets use
inline functions.)

I'm going to say review-, but I'd love to see a version of this that used
inline functions instead.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list