[Webkit-unassigned] [Bug 20973] [Qt] SVG patterns are missing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20973


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23629|review?                     |review+
               Flag|                            |




------- Comment #2 from darin at apple.com  2008-09-21 13:44 PDT -------
(From update of attachment 23629)
+    PassRefPtr<Pattern> pattern;
+    pattern = Pattern::create(tile()->image(), true, true);

This is an inefficient idiom. It's more efficient to initialize on the same
line the variable is defined on. But also the local variable should be RefPtr,
not PassRefPtr. See <http://webkit.org/coding/RefPtr.html> for guidelines.

+    QBrush brush(pattern.get()->createPlatformPattern(affine));

No need for the call to get() here. You can just use the -> operator normally
with smart pointers.

r=me as-is, but I suggest making those two refinements.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.