[Webkit-unassigned] [Bug 20403] [Gtk] Segfault after a table with an iframe is attempted to be added twice to DOM model with javascript.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 21 12:22:20 PDT 2008


darin at apple.com changed:

           What    |Removed                     |Added
  Attachment #23568|review?                     |review-
               Flag|                            |

------- Comment #17 from darin at apple.com  2008-09-21 12:22 PDT -------
(From update of attachment 23568)
Yes, this is exactly the right fix!

+    notImplemented();

There's no reason to add that call. It's fine for detachedFromParent4() to be
empty and no need to call notImplemented().

The change looks fine, but there's no ChangeLog nor test case, so I'm going to
say review-. Please submit a new patch with ChangeLog. If this was a platform
where layout tests were working well, I'd insist on a test case too, but I
don't think GTK is working well with regression tests yet, so I guess we're OK
without one.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list