[Webkit-unassigned] [Bug 20699] SVGPaintServer CleanUp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20699


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23625|review?                     |review-
               Flag|                            |




------- Comment #27 from eric at webkit.org  2008-09-21 07:19 PDT -------
(From update of attachment 23625)
Looks fine.  Except why are you adding:
 97 void SVGPaintServerSolid::renderPath(GraphicsContext*& context, const
RenderObject* path, SVGPaintTargetType type) const

That's already implemented exactly like that in SVGPaintServer, or?  Maybe
that's only for CG?

Also, it seems:
context->setFillRule(svgStyle->fillRule());

should go in setup() in the fill if-block not in renderPath(), or?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.