[Webkit-unassigned] [Bug 20949] Catch repeated messages in Inspector Controller to limit memory usage

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 19 17:06:50 PDT 2008


https://bugs.webkit.org/show_bug.cgi?id=20949


oliver at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23586|review?                     |review-
               Flag|                            |




------- Comment #2 from oliver at apple.com  2008-09-19 17:06 PDT -------
(From update of attachment 23586)
static ConsoleMessage* previousMessage = 0;

Is unsafe as it is global whereas InspectorController is per WebView (afaiaa)
so you could have to webviews spewing the same error and you would get
excitingly confused.

I'm also not sure what happens if i had a case where i had a repeating group of
messages -- say trying to load malformed content or some such could lead to
repeating groups of messages, but because it's not the same message over and
over in immediate succession it would not be caught.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list