[Webkit-unassigned] [Bug 20887] Legend tag should be exposed through AX

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20887


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23548|review?                     |review-
               Flag|                            |




------- Comment #2 from darin at apple.com  2008-09-18 23:30 PDT -------
(From update of attachment 23548)
 427     Node *element = m_renderer->element();

Should be Node*, not "Node *".

 1061     if (isFieldset())
 1062         return
axObjectCache()->get(static_cast<RenderFieldset*>(m_renderer)->findLegend());

This assumes that the renderer will be a RenderFieldset because the tag is
fieldsetTag. Why is that a safe assumption? Instead, both function should be
looking at hte renderer, and neither should be asking what the tag name is.

Patch otherwise looks fine. review- because of the DOM/Renderer assumption.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.