[Webkit-unassigned] [Bug 20890] Need to decouple building for the Mac from using NSURL/CFURL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20890





------- Comment #12 from amanda at chromium.org  2008-09-18 07:45 PDT -------
(In reply to comment #10)
> PLATFORM(MAC) doesn't indicate "Apple's Mac port".  We don't really have a
> macro to indicate such a thing at this time.  Perhaps we need to introduce one?
>  On Windows, for example, we indicate "Apple's Windows port" by the combination
> of PLATFORM(WIN) and PLATFORM(CG).

This is what we used as a pattern, in fact--originally we were going to go
exactly parallel with "PLATFORM(MAC) + PLATFORM(SKIA)", but PLATFORM(CHROMIUM)
made more sense, since it controls code having to do with the application
architecture, not just the graphics API.

> The Qt and Gtk ports do not set PLATFORM(MAC) when building on Mac OS X as they
> do not wish to use any of the Mac-level APIs even if they happen to be building
> on Mac OS X.  The situation may be the same for Chromium, in which case they
> may opt to leave PLATFORM(MAC) unset even if building on Mac OS X.  Otherwise,
> if they wish to use Mac-level APIs, they should define PLATFORM(MAC) and we
> should work out how to address any issues that arise from the code conflating
> PLATFORM(MAC) with "Apple's Mac port".

Indeed.  The Mac version of Chromium uses plenty of Mac APIs (so it's not
analogous to Qt), but we're not using Apple's WebView--so all of the code that
does things like crawl around the view hierarchy at runtime to invoke methods
on superviews, or has dependencies on Apple's resource loaders, etc. will fail.
 That's the sort of thing we intended to note with PLATFORM(CHROMIUM).  We *do*
want to reuse as much Apple code in WebCore as possible, which is why we didn't
fork off an entirely separate platform.

All that said, I'm happy to move the discussion to webkit-dev.  We won't be the
last project to run into this, so a more general solution would be great.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.