[Webkit-unassigned] [Bug 20868] webkit should use AX array centric API for performance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20868


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23478|review-                     |review+
               Flag|                            |




------- Comment #3 from eric at webkit.org  2008-09-16 11:59 PDT -------
(From update of attachment 23478)
There are some style violations:

This is Obj-C code, so the * goes on the right:
+            NSArray* children = [self renderWidgetChildren];
+        NSArray* widgetChildren = [self renderWidgetChildren];

No { }:
+            if (childCount > ([children count]-index))
+            {
+                childCount = ([children count]-index);
+            }

I believe it's part of our style guide that each variable gets its own line:
+        unsigned added = 0, k = index, count = children.size(), available =
MIN(count - index, maxCount);  but I guess I'd have to check.

You don't need to check nil here:
+        NSArray* widgetChildren = [self renderWidgetChildren];
+        if (widgetChildren)
+            return [widgetChildren count];
+        return 0;

return [widgetChildren count] will do the same.

Otherwise looks fine.  I assume you can fix the style on landing.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.