[Webkit-unassigned] [Bug 18994] LANG/LC_ALL influences the result of element.style.opacity

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=18994





------- Comment #19 from alp at nuanti.com  2008-09-16 07:36 PDT -------
This patch converts most, but not all String::format() callers to instead build
strings directly. There are still ~50 calls yet to be ported (listed below)
though the remaining ones are low-risk (no float/double formatting). It'd be
great to drop String::format() completely or move it well out of the way some
day since it clearly leads to sloppy code.


WebCore/css/CSSParser.cpp:        String str = String::format("%06d",
(int)(value->fValue+.5));
WebCore/dom/StyledElement.cpp:            color =
String::format("#%02x%02x%02x", colors[0], colors[1], colors[2]);
WebCore/page/Console.cpp:    String message = String(title) + String::format(":
%.0fms", elapsed);
WebCore/storage/DatabaseTracker.cpp:        filename =
pathByAppendingComponent(originPath, String::format("%016llx.db", seq));
WebCore/storage/DatabaseTracker.cpp:    if (!addDatabase(origin, name,
String::format("%016llx.db", seq)))
WebCore/loader/FTPDirectoryDocument.cpp:        return String::format("%.2f
KB", static_cast<float>(bytes)/1000);
WebCore/loader/FTPDirectoryDocument.cpp:        return String::format("%.2f
MB", static_cast<float>(bytes)/1000000);
WebCore/loader/FTPDirectoryDocument.cpp:    return String::format("%.2f GB",
static_cast<float>(bytes)/1000000000);
WebCore/loader/FTPDirectoryDocument.cpp:            timeOfDay =
String::format(", %i:%02i AM", hour, fileTime.tm_min);
WebCore/loader/FTPDirectoryDocument.cpp:            timeOfDay =
String::format(", %i:%02i PM", hour, fileTime.tm_min);
WebCore/loader/FTPDirectoryDocument.cpp:        dateString = String::format("%s
%i, %i", months[month], fileTime.tm_mday, fileTime.tm_year);
WebCore/loader/FTPDirectoryDocument.cpp:        dateString = String::format("%s
%i, %i", months[month], fileTime.tm_mday, now.tm_year);
WebCore/loader/archive/cf/LegacyWebArchive.cpp:    String iframeMarkup =
String::format("<iframe frameborder=\"no\" marginwidth=\"0\" marginheight=\"0\"
width=\"98%%\" height=\"98%%\" src=\"%s\"></iframe>", 
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:            return
String::format("U+%04X", toupper(keyCode));
WebCore/platform/wx/KeyboardEventWx.cpp:            return
String::format("U+%04X", toupper(keyCode));
WebCore/platform/gtk/KeyEventGtk.cpp:            return
String::format("U+%04X", gdk_keyval_to_unicode(gdk_keyval_to_upper(keyCode)));
WebCore/platform/mac/KeyEventMac.mm:            return String::format("U+%04X",
toASCIIUpper(c));
WebCore/platform/sql/SQLiteDatabase.cpp:   
executeCommand(String::format("PRAGMA synchronous = %i", sync));
WebCore/platform/win/ClipboardUtilitiesWin.cpp:    append(result,
String::format(header, startHTMLOffset, endHTMLOffset, startFragmentOffset,
endFragmentOffset).utf8());
WebCore/platform/win/GDIObjectCounter.cpp:    init(String::format("%s (%p)",
className.latin1().data(), instance));
WebCore/platform/win/Language.cpp:        computedDefaultLanguage =
String::format("%s-%s", languageName.latin1().data(),
countryName.latin1().data());
WebCore/platform/win/KeyEventWin.cpp:            return
String::format("U+%04X", toASCIIUpper(keyCode));
WebCore/platform/text/String.cpp:String String::format(const char *format, ...)
WebCore/platform/text/String.cpp:    return String::format("%d", n);
WebCore/platform/text/String.cpp:    return String::format("%u", n);
WebCore/platform/text/String.cpp:    return String::format("%ld", n);
WebCore/platform/text/String.cpp:    return String::format("%lu", n);
WebCore/platform/text/String.cpp:    return String::format("%I64i", n);
WebCore/platform/text/String.cpp:    return String::format("%lli", n);
WebCore/platform/text/String.cpp:    return String::format("%I64u", n);
WebCore/platform/text/String.cpp:    return String::format("%llu", n);
WebCore/platform/text/String.cpp:    return String::format("%.6lg", n);
WebCore/platform/graphics/cg/ImageBufferCG.cpp:    return
String::format("data:%s;base64,%s", mimeType.utf8().data(), out.data());
WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:            String
text = String::format("%1.2f", frameRate);
WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:           
String text = String::format("%1.2f", frameRate);
WebCore/platform/graphics/cairo/PathCairo.cpp:            string +=
String::format("M %.2f,%.2f",
WebCore/platform/graphics/cairo/PathCairo.cpp:            string +=
String::format("L %.2f,%.2f",
WebCore/platform/graphics/cairo/PathCairo.cpp:            string +=
String::format("C %.2f,%.2f,%.2f,%.2f,%.2f,%.2f",
WebCore/platform/graphics/Color.cpp:        return
String::format("#%02X%02X%02X%02X", red(), green(), blue(), alpha());
WebCore/platform/graphics/Color.cpp:    return String::format("#%02X%02X%02X",
red(), green(), blue());
WebCore/rendering/RenderMedia.cpp:    return String::format("%02d:%02d:%02d",
hours, minutes, seconds);
WebCore/rendering/RenderTreeAsText.cpp:                String hex =
String::format("\\x{%X}", u);
WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:        return
String::format("%s %s", name.sysname, name.machine);
WebKit/win/WebKitStatistics.cpp:        append(vector, String::format("%4u",
current->second));
WebKit/win/WebCoreSupport/WebInspectorClient.cpp:    // FIXME: The series of
appends should be replaced with a call to String::format()
WebKit/win/WebView.cpp:        osVersion = String::format("Windows NT %d.%d",
versionInfo.dwMajorVersion, versionInfo.dwMinorVersion);
WebKit/win/WebView.cpp:        osVersion = String::format("Windows %d.%d",
versionInfo.dwMajorVersion, versionInfo.dwMinorVersion);
WebKit/win/WebView.cpp:        m_userAgentStandard =
String::format("Mozilla/5.0 (Windows; U; %s; %s) AppleWebKit/%s (KHTML, like
Gecko)%s%s", osVersion().latin1().data(), defaultLanguage().latin1().data(),
webKitVersion().latin1().data(), (m_applicationName.length() ? " " : ""),
m_applicationName.latin1().data());


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.