[Webkit-unassigned] [Bug 17719] Qt, Cairo and wx require toDataURL implementations
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 16 00:36:02 PDT 2008
https://bugs.webkit.org/show_bug.cgi?id=17719
eric at webkit.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23464|review? |review-
Flag| |
------- Comment #6 from eric at webkit.org 2008-09-16 00:36 PDT -------
(From update of attachment 23464)
Looks good to me.
static cairo_status_t writeFunction(void *closure, const unsigned char *data,
unsigned int length)
98102 {
99 notImplemented();
100 return String();
103 Vector<char> *in = (Vector<char> *) closure;
104 in->append(data, length);
105 return CAIRO_STATUS_SUCCESS;
106 }
Has style issues. * placement, and the c-style cast (Vector<char> *) should be
a reinterpret_cast<Vector<char>*> instead. Unfortunately you don't yet have
commit-bit :( so I'll ask you to post another patch (which I don't need to see,
but is needed for someone else to land).
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list