[Webkit-unassigned] [Bug 11225] No scroll bars are displayed for standalone SVG image

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=11225





------- Comment #16 from sam at webkit.org  2008-09-15 22:53 PDT -------
(From update of attachment 23447)
+        Reviewed by Eric Seidel.
We tend not to put anything in here when submitting patches.


+        sizes or positions when an SVG document is scrolled. Added a layout
test to
+        demonstrate the problem and the fix, and modified expected results of
some layout
+        tests trivially impacted by this change.
This information is not really needed in the ChangeLog.  Instead, you should
try and chronicle the specifics of what changed next to the files/functions
that were changed below.

+        * ChangeLog:
No need to include this.
+>>>>>>> .r36446
This needs to be removed.

+        // Except in the case where the SVG element is the document; in that
case we want to scroll if necessary
An element cannot be a document, so this comment seems wrong.  Perhaps you mean
the svg element is the root element of a document.

+    bool relayoutChildren = selfNeedsLayout() || 
+        (m_width != oldWidth || m_height != oldHeight || m_viewport !=
oldViewport);
The parenthesis are not needed.

Can you explain why the changes to layout tests happened?  You note that it is
trivial, but what caused it?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.