[Webkit-unassigned] [Bug 20839] New: QtWebkit fails to build on Darwin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20839

           Summary: QtWebkit fails to build on Darwin
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit Qt
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jeandanielguyot at yahoo.fr


- Version of Qt : 4.4.1 
- Mac OS X.5

Here are some steps to reproduce the issue :

1. Get a fresh svn version of Webkit
2. Set QMAKESPEC to "macx-g++" (#15614)
3. Run ./WebKitTools/Scripts/build-webkit --qt --release

After a while, you get this error:

g++ -c -pipe -Wreturn-type -fno-strict-aliasing -Os -fvisibility=hidden
-fvisibility-inlines-hidden -fPIC -DBUILDING_QT__=1 -DUSE_SYSTEM_MALLOC
-DNDEBUG -DBUILD_WEBKIT -DWTF_USE_JAVASCRIPTCORE_BINDINGS=1 -DWTF_CHANGES=1
-DBUILDING_QT__ -DQT_NO_DEBUG -DQT_GUI_LIB -DQT_CORE_LIB -DQT_SHARED
-I/usr/local/Qt4.4/mkspecs/macx-g++ -I../../../JavaScriptCore
-I/Library/Frameworks/QtCore.framework/Versions/4/Headers -I/usr/include/QtCore
-I/Library/Frameworks/QtGui.framework/Versions/4/Headers -I/usr/include/QtGui
-I/usr/include -I../../../WebKit/qt/Api -Itmp -Itmp -I../../../JavaScriptCore
-I../../../JavaScriptCore/kjs -I../../../JavaScriptCore/wtf
-I../../../JavaScriptCore/wtf/unicode -I../../../JavaScriptCore/VM
-I../../../JavaScriptCore/profiler -I../../../JavaScriptCore/API
-I../../../../WebKit -I../../../JavaScriptCore/ForwardingHeaders
-I../../../JavaScriptCore/pcre -Ikjs/tmp -I../../../JavaScriptCore
-I../../../JavaScriptCore -I. -F/Library/Frameworks -o tmp/ThreadingQt.o
../../../JavaScriptCore/wtf/ThreadingQt.cpp
../../../JavaScriptCore/wtf/ThreadingQt.cpp: In function ‘bool
WTF::isMainThread()’:
../../../JavaScriptCore/wtf/ThreadingQt.cpp:179: error: ‘mainThreadIdentifier’
was not declared in this scope


Indeed mainThreadIdentifier is defined on all platforms but Darwin:

#if !PLATFORM(DARWIN)
static ThreadIdentifier mainThreadIdentifier;
#endif


Thus the function isMainThread fails to build

bool isMainThread()
{
    return currentThread() == mainThreadIdentifier;
}


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.