[Webkit-unassigned] [Bug 20435] Canvas missing exceptioncode for gradients

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 12 12:13:43 PDT 2008


https://bugs.webkit.org/show_bug.cgi?id=20435


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23197|review?                     |review-
               Flag|                            |




------- Comment #11 from eric at webkit.org  2008-09-12 12:13 PDT -------
(From update of attachment 23197)
This looks fine, but it *really* should use the new js test system.  see
LayoutTests/fast/js for examples.

Then things like:

+        try{
+            var gradient = ctx.createLinearGradient(0, 0, 100, -Infinity);
+            print("FAIL");
+        } catch (e) {
+            print("PASS: a -Infinity value for y1, got exception as
expected");
+        }

turn into:
shouldThrow("ctx.createLinearGradient(0, 0, 100, -Infinity)")

You could even re-write this as a loop if you really wanted to, which built up
different arg arrays.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list