[Webkit-unassigned] [Bug 20699] SVGPaintServer CleanUp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 9 09:56:22 PDT 2008


https://bugs.webkit.org/show_bug.cgi?id=20699


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23228|review?                     |review+
               Flag|                            |




------- Comment #4 from eric at webkit.org  2008-09-09 09:56 PDT -------
(From update of attachment 23228)
We should really fix dashes.  (Instead of adding an #ifdef).  Just add a
GraphicsContext::setLineDash(DashArray) function to GraphicContext, and an:
OwnPtr<DashArray> onto the GraphicsContext state, and then copy the passed in
DashArray onto the state any time the method is called.  We'd have to fix
stroke* to setup the dash calls per-platform, but I think that's teh better
long term solution.  I guess that can be a separate patch.

Does this still work for CG?  If so, then r+


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list