[Webkit-unassigned] [Bug 20589] PropertyMap speedup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20589





------- Comment #15 from ap at webkit.org  2008-09-08 03:56 PDT -------
Please mark the patches for review by clicking an Edit link and setting review?
flag to ensure that they do not get lost.

Talking only about coding style:

Please write ChangeLogs as per <http://webkit.org/coding/contributing.html>.
You can use prepare-ChangeLog script to make a stub, and add actual information
to it.

+    numLookupMiss++;
We prefer prefix notation. It obviously makes no difference here, but for
iterator objects, it can be faster, and it's good to use a common style
everywhere.

+    if (m_u.table->keyLookup1 && m_u.table->keyLookup1 == rep) {
+        m_u.table->entryLookup1 = 0;
+    }

We do not put braces around single line blocks.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.