[Webkit-unassigned] [Bug 20716] New: FrameLoader should delegate NewWindow browser policy decision
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 8 03:52:11 PDT 2008
https://bugs.webkit.org/show_bug.cgi?id=20716
Summary: FrameLoader should delegate NewWindow browser policy
decision
Product: WebKit
Version: 528+ (Nightly build)
Platform: All
OS/Version: All
Status: UNCONFIRMED
Severity: Major
Priority: P3
Component: WebCore Misc.
AssignedTo: webkit-unassigned at lists.webkit.org
ReportedBy: anton.tarasov at sun.com
FrameLoader::continueAfterNewWindowPolicy method, unlike
FrameLoader::continueAfterNavigationPolicy method, doesn't delegate
policy decision to the client.
The latter does it as follows:
-----
case PolicyUse: {
ResourceRequest request(check.request());
if (!m_client->canHandleRequest(request)) {
handleUnimplementablePolicy(
m_client->cannotShowURLError(check.request()));
check.clearRequest();
shouldContinue = false;
}
break;
}
check.call(shouldContinue);
-----
I guess some similar approach should be implemented in
continueAfterNewWindowPolicy.
Respectively, FrameLoaderClient.h should provide a method like
CanOpenNewWindow.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list