[Webkit-unassigned] [Bug 17537] Try MIME before trying IANA names when enumerating ICU converters
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Sep 7 05:02:56 PDT 2008
https://bugs.webkit.org/show_bug.cgi?id=17537
ap at webkit.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23219|review?(ap at webkit.org) |review-
Flag| |
------- Comment #12 from ap at webkit.org 2008-09-07 05:02 PDT -------
(From update of attachment 23219)
OK, let's do this.
> Yeah, IBM codepage designations and MS-DOS codepage designations are not
> completely in sync.
Would it be possible to specify what exactly changes in this regard with this
patch, if only for posterity?
+2008-09-05 jungshik <set EMAIL_ADDRESS environment variable>
Please fix this.
> I didn't use strcasecmp or stricmp because neither is portable
We can use strncasecmp from wtf/StringExtras.h. Also, I think that this line
needs a comment - otherwise it's not clear from just looking at the code why we
use case-insensitive compare in this single case only.
I'm going to say r- for you to consider my comments, but really it's an r+, as
the only thing that absolutely must be fixed is the ChangeLog.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list