[Webkit-unassigned] [Bug 18346] [GTK] Remove build warnings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=18346





------- Comment #9 from gns at gnome.org  2008-09-05 20:13 PDT -------
(In reply to comment #8)
> >diff --git a/WebKit/gtk/WebCoreSupport/ContextMenuClientGtk.cpp b/WebKit/gtk/WebCoreSupport/ContextMenuClientGtk.cpp
> >index 8888f2b..00b3057 100644
> >--- a/WebKit/gtk/WebCoreSupport/ContextMenuClientGtk.cpp
> >+++ b/WebKit/gtk/WebCoreSupport/ContextMenuClientGtk.cpp
> >@@ -86,7 +86,7 @@ static const GtkUnicodeMenuEntry bidi_menu_entries[] = {
> > 
> > static void insertControlCharacter(GtkWidget* widget)
> > {
> >-    GtkUnicodeMenuEntry* entry = (GtkUnicodeMenuEntry*)g_object_get_data(G_OBJECT(widget), "gtk-unicode-menu-entry");
> >+    // GtkUnicodeMenuEntry* entry = (GtkUnicodeMenuEntry*)g_object_get_data(G_OBJECT(widget), "gtk-unicode-menu-entry");
> >     notImplemented();
> > }
> > 
> 
> Normally we try to avoid commented-out code but in this case it's the only hint
> as to what's going on and what the author intended, so I'm OK with your change
> here to fix the warning.

Yeah, that's why I decided to leave it. I also left some static functions which
are generating warnings untouched, as they will probably still be called when
the missing implementation comes into place.

> Looks good to land after suggested changes.

Just building webkit again to test that they are correct and will upload a new
patch. Thanks for the quick review!


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.