[Webkit-unassigned] [Bug 20667] Animation of -webkit-transform matrix() function should not do linear interpolation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20667


sam at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23195|review?                     |review-
               Flag|                            |




------- Comment #2 from sam at webkit.org  2008-09-05 10:33 PDT -------
(From update of attachment 23195)
Just style nits.

+    double sx, sy;
+    double angle;
We don't usually pre declare variables.

+    /* Compute scaling factors. */
We tend to use C++ style comments.  This issue is in a few 

+    sx = sqrt (m.a() * m.a() + m.b() * m.b());
+    sy = sqrt (m.c() * m.c() + m.d() * m.d());
Space after sqrt.

+    angle = atan2 (m.b(), m.a());
Space after atan2.

+    int i;
No need to pre declare this.

+        srA[2] += srA[2] < 0 ? M_PI : -M_PI;
+    }
+
+    // Don't rotate the long way around.
+    srA[2] = fmod(srA[2], 2.0 * M_PI);
+    srB[2] = fmod(srB[2], 2.0 * M_PI);
+
+    if (fabs (srA[2] - srB[2]) > M_PI) {
+        if (srA[2] > srB[2])
+            srA[2] -= M_PI * 2.0;
+        else
+            srB[2] -= M_PI * 2.0;
+    }
We use piDouble/piFloat instead of M_PI


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.