[Webkit-unassigned] [Bug 20645] Duplicated constants

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20645


ggaren at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23166|review?                     |review-
               Flag|                            |




------- Comment #2 from ggaren at apple.com  2008-09-04 08:47 PDT -------
(From update of attachment 23166)
Is the point of this patch just to unique numbers and strings within a
codeblock? I think it is. For everything else, comparing JSValue* would be
enough.

Rather than making a JSValue*, then later extracting and comparing the
underlying data, I think we should just to add a version of emitLoad() for
Identifier, and one for double, which did the unique-ing based on hashes of
Identifier and double. 

That would eliminate a lot of complexity, and substantially improve the double
hash function, which in this patch just truncates the double to unsigned. It
would also reduce memory and GC pressure, in the case where you actually found
a duplicate constant (since you would avoid allocating the duplicate just to
discover that it was a duplicate).


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.