[Webkit-unassigned] [Bug 20620] Wrap uses of KJS in core classes with USE(JSC)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20620





------- Comment #15 from eric at webkit.org  2008-09-03 16:58 PDT -------
(In reply to comment #14)
> (In reply to comment #13)
> > > > Why is this change ok?
> > > > -#define ENABLE_NETSCAPE_PLUGIN_API 0
> > > > +#define ENABLE_NETSCAPE_PLUGIN_API 1
> > > 
> > > Yup.  All platforms had it on.  Platforms can still turn it off by defining
> > > than as part of their build system.
> > 
> > What do you mean by "All platforms had it on"?  Wx doesn't support NPAPI, nor
> > does Gtk on Windows.

It seems that Platform.h from ToT doesn't agree with you:
 #if (PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(SYMBIAN) || PLATFORM(WIN) ||
PLATFORM(WX)) && !defined(ENABLE_NETSCAPE_PLUGIN_API)
#define ENABLE_NETSCAPE_PLUGIN_API 1
#endif

My change is correct at least for the two examples you posted.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.