[Webkit-unassigned] [Bug 20620] Wrap uses of KJS in core classes with USE(JAVASCRIPTCORE_BINDINGS)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20620





------- Comment #12 from eric at webkit.org  2008-09-03 15:42 PDT -------
(In reply to comment #10)
> (From update of attachment 23149 [edit])
> This comment is not necessary.  
> +/* Chromium runs WebKit multi-process/sandboxed, and provides its own */
> +/* OS-level abstractions to work in this environment. */

OK, I figured all the other platforms had (vacuous) comments, I should add one
too. :)

> Will this break windows builds that use CG?
> +/* Makes PLATFORM(WIN) default to PLATFORM(CAIRO) */
> +#if !PLATFORM(MAC) && !PLATFORM(QT) && !PLATFORM(WX)

Nah, this is kinda strange, but the Apple windows build fixes up its defines in
WebCore/config.h

Basically we need a better way to define what you're building.  Window-Apple,
Windows-Cairo, Windows-Chromium, etc.

> Why not do this in Platform.h
> +#if !defined(WTF_USE_JAVASCRIPTCORE_BINDINGS) && !defined(WTF_USE_V8_BINDINGS)
> +/* Currently Chromium is the only platform which uses V8 by default */
> +#if PLATFORM(CHROMIUM)
> +#define WTF_USE_JAVASCRIPTCORE_BINDINGS 0
> +#define WTF_USE_V8_BINDINGS 1
> +#else
> +#define WTF_USE_JAVASCRIPTCORE_BINDINGS 1
> +#define WTF_USE_V8_BINDINGS 0
> +#endif /* PLATFORM(CHROMIUM) */
> +#endif /* !defined(WTF_USE_JAVASCRIPTCORE_BINDINGS) &&
> !defined(WTF_USE_V8_BINDINGS) */

Cause Platform.h is part of JavaScriptCore, and this stuff had been part of
WebCore in the past.

> Why is this change ok?
> -#define ENABLE_NETSCAPE_PLUGIN_API 0
> +#define ENABLE_NETSCAPE_PLUGIN_API 1

Yup.  All platforms had it on.  Platforms can still turn it off by defining
than as part of their build system.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.