[Webkit-unassigned] [Bug 20495] paintBorder in RenderObject paint two times the corners

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20495


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23099|review?                     |review-
               Flag|                            |




------- Comment #9 from eric at webkit.org  2008-09-02 03:14 PDT -------
(From update of attachment 23099)
I can't evaluate the correctness of this patch, but I can say that the
copy-paste code used here is a bad idea.

The if should be used to store the necessary variables, and then a single
drawBorder call should be used.

It appears that you're changing where it's drawing from/to.  It seems the code
right above this adjusts y and y2 in an if, why can't this change also do the
same? (use an if to adjust y and y2?  or copy y and y2 into some other nicely
named variables and ajust them there).  Copy/paste of code which is confusing
to begin with is a bad idea.  Ideally this method would be cleaned up to use
FloatPoint and possibly to take fewer parameters :)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.