[Webkit-unassigned] [Bug 22008] Add windows support for selecting multiple files in a file upload control

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22008


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24818|review?(darin at apple.com)    |review+
               Flag|                            |




------- Comment #4 from darin at apple.com  2008-10-31 16:17 PDT -------
(From update of attachment 24818)
> +    if (_tcscat_s(buffer, ARRAYSIZE(buffer), TEXT("\\shell32.dll")))

As we discussed in person, you can leave out the ARRAYSIZE here and it will get
the size automatically, and you should. Same in the other _tcscat_s call site.

> +// When you call GetOpenFileName, if the size of the buffer is too small,
> +// MSDN says that the first two bytes of the buffer contain the required size for the file selection, in bytes or characters
> +// So we can assume the required size can't be more than the maximum value for a short.
> +static const unsigned short maxFilePathsListSize = USHRT_MAX;

This should be size_t.

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.