[Webkit-unassigned] [Bug 19392] [Gtk] Enable WebInspector in the Gtk port
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 29 15:04:09 PDT 2008
https://bugs.webkit.org/show_bug.cgi?id=19392
------- Comment #26 from freyther at handhelds.org 2008-10-29 15:04 PDT -------
(From update of attachment 23014)
Pretty good. Some minor comments for the future:
Please use WebKitTools/Scripts/prepare-ChangeLog to generate the ChangeLog.
Your commenting style was really mixed, sadly we favor c++ comments (//),
please try to be consistent.
In InspectorClient::inspectorDestroyed, it might be wise to initialize
m_webInspector and then check for if (m_webInspector)..
And I also get this from the gobject runtime: (GtkLauncher:12425):
GLib-GObject-WARNING **: /build/buildd/glib2.0-2.18.2/gobject/gsignal.c:2267:
signal `destroy' is invalid for instance `0x8842b60'
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list